Re: [libvirt PATCH 7/9] remote: Add support for the virConnectGetHypervisorCPUModelDefinition API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 28, 2022 at 06:09:44PM +0200, Tim Wiederhake wrote:
> Signed-off-by: Tim Wiederhake <twiederh@xxxxxxxxxx>
> ---
>  src/remote/remote_daemon_dispatch.c | 32 ++++++++++++++++++++++
>  src/remote/remote_driver.c          | 41 +++++++++++++++++++++++++++++
>  src/remote/remote_protocol.x        | 20 +++++++++++++-
>  src/remote_protocol-structs         | 11 ++++++++
>  4 files changed, 103 insertions(+), 1 deletion(-)


> diff --git a/src/remote/remote_protocol.x b/src/remote/remote_protocol.x
> index a5c60399c7..2d7d6277c6 100644
> --- a/src/remote/remote_protocol.x
> +++ b/src/remote/remote_protocol.x
> @@ -3314,6 +3314,18 @@ struct remote_connect_get_hypervisor_cpu_model_names_ret {
>      int ret;
>  };
>  
> +struct remote_connect_get_hypervisor_cpu_model_definition_args {
> +    remote_nonnull_string arch;
> +    remote_nonnull_string machine;
> +    remote_nonnull_string name;
> +    unsigned int flags;
> +};
> +
> +struct remote_connect_get_hypervisor_cpu_model_definition_ret {
> +    remote_nonnull_string xml;
> +    int ret;
> +};

'ret' should not be here, as errors are encoded separately on
the wire.


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux