Re: [PATCH RFC v2 2/3] qemu_capabilities: add "query-stats" QMP command to the QEMU capabilities

[Martin Kletzander <mkletzan@xxxxxxxxxx>]

On Wed, Jul 06, 2022 at 04:56:27AM +0530, Amneesh Singh wrote:
> Related: https://gitlab.com/libvirt/libvirt/-/issues/276
>
> This patch adds "query-stats" to the QEMU capabilities.
>
> Signed-off-by: Amneesh Singh <natto@xxxxxxxxxxxxx>
> ---
> src/qemu/qemu_capabilities.c | 2 ++
> src/qemu/qemu_capabilities.h | 1 +
> 2 files changed, 3 insertions(+)
>
> diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
> index 2c3be3ec..81fc597a 100644
> --- a/src/qemu/qemu_capabilities.c
> +++ b/src/qemu/qemu_capabilities.c
> @@ -671,6 +671,7 @@ VIR_ENUM_IMPL(virQEMUCaps,
>               "chardev.qemu-vdagent", /* QEMU_CAPS_CHARDEV_QEMU_VDAGENT */
>               "display-dbus", /* QEMU_CAPS_DISPLAY_DBUS */
>               "iothread.thread-pool-max", /* QEMU_CAPS_IOTHREAD_THREAD_POOL_MAX */
> +              "query-stats", /* QEMU_CAPS_QUERY_STATS */
>     );
>
>
> @@ -1225,6 +1226,7 @@ struct virQEMUCapsStringFlags virQEMUCapsCommands[] = {
>     { "query-dirty-rate", QEMU_CAPS_QUERY_DIRTY_RATE },
>     { "sev-inject-launch-secret", QEMU_CAPS_SEV_INJECT_LAUNCH_SECRET },
>     { "calc-dirty-rate", QEMU_CAPS_CALC_DIRTY_RATE },
> +    { "query-stats", QEMU_CAPS_QUERY_STATS },
> };
>
> struct virQEMUCapsStringFlags virQEMUCapsMigration[] = {
> diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h
> index 6f35ba14..29e55b3a 100644
> --- a/src/qemu/qemu_capabilities.h
> +++ b/src/qemu/qemu_capabilities.h
> @@ -650,6 +650,7 @@ typedef enum { /* virQEMUCapsFlags grouping marker for syntax-check */
>     QEMU_CAPS_CHARDEV_QEMU_VDAGENT, /* -chardev qemu-vdagent */
>     QEMU_CAPS_DISPLAY_DBUS, /* -display dbus */
>     QEMU_CAPS_IOTHREAD_THREAD_POOL_MAX, /* -object iothread.thread-pool-max */
> +    QEMU_CAPS_QUERY_STATS,  /*accepts query-stats */

missing space after /*

with that

Reviewed-by: Martin Kletzander <mkletzan@xxxxxxxxxx>

>     QEMU_CAPS_LAST /* this must always be the last item */
> } virQEMUCapsFlags;
> --
> 2.36.1

Attachment: signature.asc
Description: PGP signature