On Sat, Apr 03, 2010 at 02:10:50AM -0400, Laine Stump wrote: > On 04/02/2010 03:51 PM, Daniel Veillard wrote: > > Change w.r.t. version 1 is the saving path under /var/lib and not > >/var/run, the restore bug fix spotted by Laine > > My test verifies this bug is fixed. > > I am s now seeing a different problem, but I'm fairly certain it's > unrelated to your patch, and is instead a race condition in the qemu > domain restore code that I've seen before (and that seems to not > show up on other people's hardware) - if the domain is paused prior > to the save, it will restore properly, and function once unpaused, > but if it's running during the save, restore will have strange > results unless I step through the code with gdb. > > So, from a functional point of view, I can ACK this. (I haven't > don't the thorough review of the source that Eric has, though.) Okay, after a final cleanup based on Eric's review, I pushed this patch set, thanks ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/ -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list