Re: [PATCH v2] conf: virDomainMemoryDefValidate: Improve error message

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/28/22 05:53, Liu Yiding wrote:
> An explicit limit would be more user friendly. Add the limit to error message.
> 
> Before this commit:
> ```
> error: requested size must be smaller than or equal to @size
> ```
> 
> Now:
> ```
> error: requested size must be smaller than or equal to @size (8388608KiB)
> ```
> 
> Signed-off-by: Liu Yiding <liuyd.fnst@xxxxxxxxxxx>
> ---
>  src/conf/domain_validate.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 

Yup, this looks perfect. Thanks!

Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx>

and pushed. Congratulations on your first libvirt contribution!

Michal




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux