On 6/17/22 10:00, Daniel P. Berrangé wrote: > On Fri, Jun 17, 2022 at 09:09:09AM +0200, Michal Prívozník wrote: >> On 6/16/22 17:36, Daniel P. Berrangé wrote: >>> See commit 2 for the example usage >>> >>> Daniel P. Berrangé (2): >>> tools: add helper method for printing an XML document >>> tools: add '--xpath EXPRESSION --wrap' args to all dumpxml commands >>> >>> docs/manpages/virsh.rst | 138 ++++++++++++++++++++++++++++++++++----- >>> tools/virsh-backup.c | 17 ++++- >>> tools/virsh-checkpoint.c | 17 ++++- >>> tools/virsh-domain.c | 55 +++++++++++++--- >>> tools/virsh-interface.c | 22 +++++-- >>> tools/virsh-network.c | 47 +++++++++---- >>> tools/virsh-nodedev.c | 17 ++++- >>> tools/virsh-nwfilter.c | 51 ++++++++++----- >>> tools/virsh-pool.c | 27 +++++--- >>> tools/virsh-secret.c | 18 ++++- >>> tools/virsh-snapshot.c | 17 ++++- >>> tools/virsh-util.c | 59 +++++++++++++++++ >>> tools/virsh-util.h | 7 ++ >>> tools/virsh-volume.c | 28 +++++--- >>> 14 files changed, 436 insertions(+), 84 deletions(-) >>> >> >> So this allows virsh dumpxml --wrap $dom, but I guess that's okay. No >> harm done. > > I did wonder about calling it --xpwrap or --xpath-wrap too, > and could add error checking if desired Nah, I think you're good. Push it as is. If somebody complains we can add error checking later. Then again, it's harmless. Michal
