On Tue, Jun 14, 2022 at 01:52:28PM +0100, Daniel P. Berrangé wrote: > On Tue, Jun 14, 2022 at 02:39:46PM +0200, Peter Krempa wrote: > > Pushed as a build fix. Whether that syntax check is a sensible use of > > CPU cycles is for another discussion. > > po/LINGUAS is created by weblate automatically with no human > interaction, so if we don't accept whatever weblate gives > us we won't be able to merge changes from weblate.... > > ...except that due to an accident with our CI we've not > blocked on that. > > Our CI is accidentally triggering on both branch pushes > and merge requests, and the merge request trigger doesnt > run the syntax-check job. > > We need to drop that syntax-check rule, and also fix our > CI. I added the syntax-check rule without realizing that the file was automatically generated. I agree that we should drop it. But at least it made us spot an issue in our CI, so it wasn't all for nothing :) -- Andrea Bolognani / Red Hat / Virtualization
