On 6/8/22 15:27, Peter Krempa wrote: > On Wed, Jun 08, 2022 at 15:25:13 +0200, Michal Privoznik wrote: >> Virsh has iothreadset command which allows setting various >> attributes of IOThreads. However, when the command is called >> without any arguments (besides domain and IOThread IDs), then >> @params stays NULL and is passed to virDomainSetIOThreadParams() >> which produces rather user unfriendly error message: >> >> error: params in virDomainSetIOThreadParams must not be NULL >> >> Introduce a check and produce better error message. >> >> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> >> --- >> tools/virsh-domain.c | 5 +++++ >> 1 file changed, 5 insertions(+) > > I've ran into this when testing your series :) Yeah, I've tested my v3 that I'm about to send thoroughly and found this issue. And of course it's at the beginning of my branch, so thanks for quick review - I can now just send v3. Michal
