On 6/7/2022 10:15 PM, Ján Tomko wrote:
> On a Saturday in 2022, Peng Liang wrote:
>> Signed-off-by: Peng Liang <tcx4c70@xxxxxxxxx>
>> ---
>> src/access/viraccessdriver.h | 1 -
>> src/access/viraccessdriverpolkit.c | 4 ----
>> src/access/viraccessdriverstack.c | 1 -
>> src/access/viraccessmanager.h | 1 -
>> src/access/viraccessperm.h | 1 -
>> 5 files changed, 8 deletions(-)
>>
>> diff --git a/src/access/viraccessperm.h b/src/access/viraccessperm.h
>> index 051246a7b6..b0ee36ed3a 100644
>> --- a/src/access/viraccessperm.h
>> +++ b/src/access/viraccessperm.h
>> @@ -20,7 +20,6 @@
>>
>> #pragma once
>>
>> -#include "internal.h"
>
> While internal.h might be unused here, I'd rather not remove it.
>
> Besides being very commonly used it also contains things for backward
> compatibility with older Glib versions. If we forget to re-add it
> later, libvirt might silently misbehave with older Glib.
>
> Jano
OK, I'll stop removing it in the next version.
And thanks for your reviewing!
Thanks,
Peng
>
>> #include "virenum.h"
>>
>> typedef enum {
>> --
>> 2.36.1
>>
