On Wed, Jun 01, 2022 at 14:50:16 +0200, Jiri Denemark wrote:
> Signed-off-by: Jiri Denemark <jdenemar@xxxxxxxxxx>
> ---
>
> Notes:
> Version 2:
> - dropped DeviceNotFound QMP error handling and replaced it with
> reporting an error if the VIR_DOMAIN_ABORT_JOB_POSTCOPY flag is used
> for something else than outgoing post-copy migration
>
> src/qemu/qemu_driver.c | 48 +++++++++++++++++++++++++++---------
> src/qemu/qemu_monitor.c | 9 +++++++
> src/qemu/qemu_monitor.h | 3 +++
> src/qemu/qemu_monitor_json.c | 19 ++++++++++++++
> src/qemu/qemu_monitor_json.h | 3 +++
> 5 files changed, 71 insertions(+), 11 deletions(-)
> diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c
> index 99c5e1b40f..8b81a07429 100644
> --- a/src/qemu/qemu_monitor_json.c
> +++ b/src/qemu/qemu_monitor_json.c
[...]
> @@ -3455,6 +3455,25 @@ int qemuMonitorJSONMigrateCancel(qemuMonitor *mon)
> }
>
>
> +int
> +qemuMonitorJSONMigratePause(qemuMonitor *mon)
> +{
> + g_autoptr(virJSONValue) cmd = NULL;
> + g_autoptr(virJSONValue) reply = NULL;
> +
> + if (!(cmd = qemuMonitorJSONMakeCommand("migrate-pause", NULL)))
> + return -1;
Even for argument-less commands we still perform validation in form of
checking whether the command is not e.g. deprecated; thus please add a
qemumonitorjsontest case even for this trivial command.
