On Fri, Apr 02, 2010 at 02:11:07PM -0400, Stefan Berger wrote:
> The attached patch optimizes the validation of the name of an interface.
>
> Signed-off-by: Stefan Berger
>
> Index: libvirt-acl/src/conf/domain_conf.c
> ===================================================================
> --- libvirt-acl.orig/src/conf/domain_conf.c
> +++ libvirt-acl/src/conf/domain_conf.c
> @@ -1795,7 +1795,7 @@ cleanup:
>
> static bool
> isValidIfname(const char *ifname) {
> - return (strspn(ifname, VALID_IFNAME_CHARS) == strlen(ifname));
> + return ifname[strspn(ifname, VALID_IFNAME_CHARS)] == 0;
> }
ACK,
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list