On Thu, Jun 02, 2022 at 10:15:41 +0200, Peter Krempa wrote: > On Thu, Jun 02, 2022 at 09:18:01 +0200, Michal Privoznik wrote: > > Our public API offers virDomainSetIOThreadParams() function which > > allows users to set various aspects of IOThreads. Introduce two > > new typed parameters: VIR_DOMAIN_IOTHREAD_THREAD_POOL_MIN and > > VIR_DOMAIN_IOTHREAD_THREAD_POOL_MAX which will allow users to > > modify the thread-pool-min and thread-pool-max attributes of an > > iothread. > > > > Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> > > --- > > include/libvirt/libvirt-domain.h | 18 ++++++++++++++++++ > > 1 file changed, 18 insertions(+) > > > > diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h > > index 24846046aa..e1daa7a91d 100644 > > --- a/include/libvirt/libvirt-domain.h > > +++ b/include/libvirt/libvirt-domain.h > > @@ -2493,6 +2493,24 @@ int virDomainDelIOThread(virDomainPtr domain, > > */ > > # define VIR_DOMAIN_IOTHREAD_POLL_SHRINK "poll_shrink" > > > > +/** > > + * VIR_DOMAIN_IOTHREAD_THREAD_POOL_MIN: > > So here you call the enum THREAD_POOL_MIN ... as noted we should do the > same in the XML. > > > + * > > + * Set the lower bound. > > This could use some more description. Don't forget to mention what value type is expected (long vs int). I'm putting it up vague as I dispute the usability of long long in this instance.
