We want to prevent our error path that can potentially kill the domain
on the destination host from overwriting an error reported earlier, but
we were only doing so in one specific path when starting vCPUs fails.
Let's do it in all paths.
Signed-off-by: Jiri Denemark <jdenemar@xxxxxxxxxx>
Reviewed-by: Peter Krempa <pkrempa@xxxxxxxxxx>
Reviewed-by: Pavel Hrdina <phrdina@xxxxxxxxxx>
---
Notes:
Version 2:
- no change
src/qemu/qemu_migration.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index fdc93d7fe1..10c4f7a470 100644
--- a/src/qemu/qemu_migration.c
+++ b/src/qemu/qemu_migration.c
@@ -5966,11 +5966,6 @@ qemuMigrationDstFinish(virQEMUDriver *driver,
if (virGetLastErrorCode() == VIR_ERR_OK)
virReportError(VIR_ERR_INTERNAL_ERROR,
"%s", _("resume operation failed"));
- /* Need to save the current error, in case shutting
- * down the process overwrites it
- */
- virErrorPreserveLast(&orig_err);
-
/*
* In v3 protocol, the source VM is still available to
* restart during confirm() step, so we kill it off
@@ -6043,6 +6038,10 @@ qemuMigrationDstFinish(virQEMUDriver *driver,
return dom;
error:
+ /* Need to save the current error, in case shutting down the process
+ * overwrites it. */
+ virErrorPreserveLast(&orig_err);
+
if (virDomainObjIsActive(vm)) {
if (doKill) {
qemuProcessStop(driver, vm, VIR_DOMAIN_SHUTOFF_FAILED,
--
2.35.1
