Re: [PATCH] ci: Refresh generated files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 27, 2022 at 12:45:17PM +0100, Daniel P. Berrangé wrote:
On Fri, May 27, 2022 at 01:37:10PM +0200, Martin Kletzander wrote:
Notable changes:

* 'lcitool manifest' now generates absolute include paths

Signed-off-by: Martin Kletzander <mkletzan@xxxxxxxxxx>
---
Pushed under the 'build-breaker' and 'just-ci-update' rules (just in case the latter also exists).

Unfortunately this change is not needed and won't fix the
reported build problem. We need the .gitlab-ci.yml to
add 'optional: true' to the 'needs:' in the failing jobs.


It took me a while to understand it, but what you're saying is that the
container jobs are not even defined if the dockerfiles are not changed
and hence the dependency cannot be resolved?  If that's it then good, if
not, then I'm baffled once again.


 ci/gitlab.yml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/ci/gitlab.yml b/ci/gitlab.yml
index 379a41111cab..cab4e6074c21 100644
--- a/ci/gitlab.yml
+++ b/ci/gitlab.yml
@@ -5,8 +5,8 @@
 # https://gitlab.com/libvirt/libvirt-ci

 include:
-  - local: 'ci/gitlab/container-templates.yml'
-  - local: 'ci/gitlab/build-templates.yml'
-  - local: 'ci/gitlab/sanity-checks.yml'
-  - local: 'ci/gitlab/containers.yml'
-  - local: 'ci/gitlab/builds.yml'
+  - local: '/ci/gitlab/container-templates.yml'
+  - local: '/ci/gitlab/build-templates.yml'
+  - local: '/ci/gitlab/sanity-checks.yml'
+  - local: '/ci/gitlab/containers.yml'
+  - local: '/ci/gitlab/builds.yml'
--
2.35.1


With regards,
Daniel
--
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux