Re: [libvirt PATCH v2 5/7] ci: Don't mark any Fedora 36 job as optional

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 26, 2022 at 04:01:50PM +0200, Andrea Bolognani wrote:
> It's a stable distro, so we expect all jobs to succeed.
> 
> Signed-off-by: Andrea Bolognani <abologna@xxxxxxxxxx>
> ---
>  ci/gitlab/containers.yml | 2 +-
>  ci/manifest.yml          | 1 -
>  2 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/ci/gitlab/containers.yml b/ci/gitlab/containers.yml
> index 5b8a91c295..37c179c439 100644
> --- a/ci/gitlab/containers.yml
> +++ b/ci/gitlab/containers.yml
> @@ -299,7 +299,7 @@ s390x-debian-sid-container:
>  
>  mingw32-fedora-36-container:
>    extends: .container_job
> -  allow_failure: true
> +  allow_failure: false
>    variables:
>      NAME: fedora-36-cross-mingw32
>  
> diff --git a/ci/manifest.yml b/ci/manifest.yml
> index e85a01018e..ad0ec9a53d 100644
> --- a/ci/manifest.yml
> +++ b/ci/manifest.yml
> @@ -157,7 +157,6 @@ targets:
>        - arch: x86_64
>  
>        - arch: mingw32
> -        allow-failure: true

There must be a hysterical raisin for this (not that I object to the patch),
maybe there was a bug in mingw toolchain giving us a hard time? I don't think
it has anything to do with the given OS's stability as the commit message
suggest, but if you don't remember and don't feel like digging, sure you can
keep the commit message as is.

Reviewed-by: Erik Skultety <eskultet@xxxxxxxxxx>




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux