On 5/23/22 3:08 PM, Michal Privoznik wrote:
The virDomainDiskSourcePoolDefParse() function uses old style of parsing XML (virXMLPropString + str2enum conversion). Use virXMLPropEnumDefault() which encapsulates those steps.
virXMLPropEnum (above and in subject)
Signed-off-by: Michal Privoznik<mprivozn@xxxxxxxxxx> --- src/conf/domain_conf.c | 12 ++++-------- src/conf/storage_source_conf.h | 2 +- 2 files changed, 5 insertions(+), 9 deletions(-)
Besides above and what I commented in patch 4 Reviewed-by: Boris Fiuczynski <fiuczy@xxxxxxxxxxxxx> -- Mit freundlichen Grüßen/Kind regards Boris Fiuczynski IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Gregor Pillen Geschäftsführung: David Faller Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294
