Re: [PATCH 09/17] virDomainDiskDefMirrorParse: Switch to virXMLPropEnumDefault()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 5/23/22 3:08 PM, Michal Privoznik wrote:
The virDomainDiskDefMirrorParse() function uses old style of
parsing XML (virXMLPropString + str2enum conversion). Use
virXMLPropEnumDefault() which encapsulates those steps.

... and virXMLPropEnum()


Signed-off-by: Michal Privoznik<mprivozn@xxxxxxxxxx>
---
  src/conf/domain_conf.c  | 26 ++++++++++----------------
  src/conf/domain_conf.h  |  4 ++--
  src/qemu/qemu_process.c |  6 ++++--
  3 files changed, 16 insertions(+), 20 deletions(-)

Besides above and what I commented in patch 4

Reviewed-by: Boris Fiuczynski <fiuczy@xxxxxxxxxxxxx>

--
Mit freundlichen Grüßen/Kind regards
   Boris Fiuczynski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Gregor Pillen
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294





[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux