Re: [libvirt PATCH 59/80] qemu: Implement VIR_MIGRATE_POSTCOPY_RESUME for Confirm phase

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 12, 2022 at 16:27:24 +0200, Peter Krempa wrote:
> On Tue, May 10, 2022 at 17:21:20 +0200, Jiri Denemark wrote:
> > Signed-off-by: Jiri Denemark <jdenemar@xxxxxxxxxx>
> > ---
> >  src/qemu/qemu_migration.c | 49 +++++++++++++++++++++++++--------------
> >  1 file changed, 32 insertions(+), 17 deletions(-)
> 
> [...]
> 
> >  
> >      if (qemuMigrationJobStartPhase(vm, phase) < 0)
> >          goto cleanup;
> >  
> >      virCloseCallbacksUnset(driver->closeCallbacks, vm,
> >                             qemuMigrationSrcCleanup);
> > +    qemuDomainCleanupRemove(vm, qemuProcessCleanupMigrationJob);
> 
> This looks out of place in context of this commit.

Sigh. I was trying hard to remember the reason I put this change into
this patch because there must have been one... but it was just a mistake
and the change belongs to [14/80] qemu: Keep migration job active after
failed post-copy.

Jirka




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux