On 19/05/2022 12.48, Gerd Hoffmann wrote:
Hi,
Oh well, I just noticed that we already have a GrabToggleKeys enum in
qapi/common.json ... I wonder whether I should try to use that instead? It
seems to be used in a slightly different context, though, if I get that
right ...?
qemu/ui/input-linux.c
Those switch the input routing between host and guest, and they act on
their own (i.e. by default both control keys without anything else).
For SDL it defines the modifiers to press in addition to the hotkeys
(i.e. ctrl + shift + 'G' for grab release, IIRC there a are more, 'F'
for fullscreen?).
So I don't think it makes sense to merge them.
Hmm, ok ... but maybe I should call the new enum HotKeyMod instead of
GrabMod to make it more obvious that it is something different?
Thomas
