On Tue, May 17, 2022 at 10:46:21 +0100, Daniel P. Berrangé wrote: > On Tue, May 17, 2022 at 02:34:00AM -0700, Andrea Bolognani wrote: > > On Tue, May 17, 2022 at 11:11:00AM +0200, Peter Krempa wrote: > > > On Tue, May 17, 2022 at 10:32:11 +0200, Andrea Bolognani wrote: > > > > These managed to sneak in as part of ec02f5719a87, when the > > > > potfile was last refreshed, but are not supposed to be there. > > > > > > > > Signed-off-by: Andrea Bolognani <abologna@xxxxxxxxxx> > > > > --- > > > > po/libvirt.pot | 216 ------------------------------------------------- > > > > 1 file changed, 216 deletions(-) > > > > > > Hmm, so is this something based perhaps on a different way how Jirka > > > generates these? I'm asking because I'm fairly certain that Jirka has a > > > script for this so that needs to be fixed too. > > > > No, you can just call the standard 'ninja libvirt-pot' target > > generated by meson and reproduce this - only sometimes, of course ;) > > > > I assume Jirka's script uses the existing functionality rather than > > reimplementing it. > > The pot files should just be imported from the pristine potfile > published by our CI job 'potfile' which is AlmaLinux8 based. > > If that's generating something bad, we need to address that. Right, I just download the generated file from https://gitlab.com/libvirt/libvirt/-/jobs/artifacts/master/download?job=potfile and push it to git. So updating the file manually without fixing the generator makes little sense as the file will be overwritten in preparation for the following release. Jirka
