On a Tuesday in 2022, Peter Krempa wrote:
Pre-construct the array the same way for the case when there's only one
FD and when there are multiple. We just change the argument name
depending on the count.
Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
---
src/qemu/qemu_command.c | 66 +++++++++++++++++++----------------------
1 file changed, 31 insertions(+), 35 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 19afad22a1..c412bc50e0 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -4215,54 +4215,50 @@ qemuBuildHostNetProps(virDomainNetDef *net,
case VIR_DOMAIN_NET_TYPE_BRIDGE:
case VIR_DOMAIN_NET_TYPE_NETWORK:
case VIR_DOMAIN_NET_TYPE_DIRECT:
- case VIR_DOMAIN_NET_TYPE_ETHERNET:
- if (virJSONValueObjectAdd(&netprops, "s:type", "tap", NULL) < 0)
- return NULL;
+ case VIR_DOMAIN_NET_TYPE_ETHERNET: {
+ g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER;
+ /* for one tapfd/vhostfd 'fd=' shall be used, for more than use 'fds=' */
s/more than/more/ Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx> Jano
Attachment:
signature.asc
Description: PGP signature
