On Fri, May 13, 2022 at 09:54:25AM +0200, Michal Privoznik wrote:
v2 of: https://listman.redhat.com/archives/libvir-list/2022-May/231307.html diff to v1: - Reworked 3/3, instead of promoting restore path to a regular argument, let's keep it in typed params as this is more future proof. But require it for now. Michal Prívozník (3): qemu: Separate out save code from qemuDomainManagedSave() lib: Repurpose virDomainSaveParams() with no VIR_DOMAIN_SAVE_PARAM_FILE virDomainRestoreFlags: Require VIR_DOMAIN_SAVE_PARAM_FILE for now
Reviewed-by: Martin Kletzander <mkletzan@xxxxxxxxxx> even though I don't particularly like it, but it seems this was the intention of Daniel and Claudio. Maybe we should mandate all new APIs to accept only typed params? /s
src/libvirt-domain.c | 6 ++- src/qemu/qemu_driver.c | 117 +++++++++++++++++++++++++---------------- 2 files changed, 77 insertions(+), 46 deletions(-) -- 2.35.1
Attachment:
signature.asc
Description: PGP signature
