Re: [PATCH v11 3/4] conf: Introduce SGX EPC element into device memory xml

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 10, 2022 at 23:11:11 -0700, Lin Yang wrote:
> <devices>
>   ...
>   <memory model='sgx-epc'>
>     <target>
>       <size unit='KiB'>512</size>
>     </target>
>   </memory>
>   ...
> </devices>
> 
> Signed-off-by: Lin Yang <lin.a.yang@xxxxxxxxx>
> ---
>  docs/formatdomain.rst                         |  9 +++-
>  src/conf/domain_conf.c                        |  6 +++
>  src/conf/domain_conf.h                        |  1 +
>  src/conf/domain_validate.c                    | 16 ++++++
>  src/conf/schemas/domaincommon.rng             |  1 +
>  src/qemu/qemu_alias.c                         |  3 ++
>  src/qemu/qemu_command.c                       |  1 +
>  src/qemu/qemu_domain.c                        | 38 +++++++++-----
>  src/qemu/qemu_domain_address.c                |  6 +++
>  src/qemu/qemu_driver.c                        |  1 +
>  src/qemu/qemu_process.c                       |  2 +
>  src/qemu/qemu_validate.c                      |  8 +++
>  src/security/security_apparmor.c              |  1 +
>  src/security/security_dac.c                   |  2 +
>  src/security/security_selinux.c               |  2 +
>  tests/qemuxml2argvdata/sgx-epc.xml            | 36 +++++++++++++
>  .../sgx-epc.x86_64-latest.xml                 | 52 +++++++++++++++++++
>  tests/qemuxml2xmltest.c                       |  2 +
>  18 files changed, 172 insertions(+), 15 deletions(-)
>  create mode 100644 tests/qemuxml2argvdata/sgx-epc.xml
>  create mode 100644 tests/qemuxml2xmloutdata/sgx-epc.x86_64-latest.xml

[...]

> diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c
> index 58ee29cd33..51f805dcab 100644
> --- a/tests/qemuxml2xmltest.c
> +++ b/tests/qemuxml2xmltest.c
> @@ -1468,6 +1468,8 @@ mymain(void)
>                    QEMU_CAPS_DEVICE_VIRTIO_RNG,
>                    QEMU_CAPS_OBJECT_RNG_RANDOM);
>  
> +    DO_TEST_CAPS_LATEST("sgx-epc");
> +

Use DO_TEST_CAPS_VER with 6.2.0 similarly to how you did in the
qemuxml2argvtest. This feature is host dependant and my host doesn't
have it. Since I periodically re-generate the latest capabilities, the
test would start failing.




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux