On Wed, May 11, 2022 at 15:25:49 +0200, Claudio Fontana wrote: > On 5/11/22 3:17 PM, Peter Krempa wrote: > > On Wed, May 11, 2022 at 14:56:35 +0200, Claudio Fontana wrote: > >> Hi Daniel, > >> > >> is this patch specifically controversial? > >> > >> I ask because this is likely to be painful to maintain. > > > > Note that in August of this year it will become obsolete. In august > > we'll be dropping support for debian-10 old qemu and thus bumping the > > minimum supported qemu to at least qemu-4.2. > > > > Additionally we have a whole separate machinery for probing the > > migration capabilities via the migration parameters, so you can > > theoreticaly replace it by that code, especially since you'll need to > > set the multifd capability when attempting the migration anyways. > > > > Thanks for the information, is the whole separate machinery the part I am > doing in this series in patch 20/27 with the multifd-compression parameter? > > Or something else entirely? Could you point me at the ropes so to speak? Basically yes. You should be able to use 'qemuMigrationCapsGet' with 'QEMU_MIGRATION_CAP_MULTIFD' to probe whether qemu supports it instead of having to add the detection yourself via qemuCaps.
