Re: [libvirt] [PATCH 10/10] Replace sscanf in PCI device address parsing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2010/3/31 Eric Blake <eblake@xxxxxxxxxx>:
> On 03/30/2010 10:20 AM, Matthias Bolte wrote:
>> This also fixes a problem with MinGW's GCC on Windows.
>> GCC complained bout the L modifier being unknown.

>>              VIR_WARN("Unusual entry in " PCI_SYSFS "devices: %s", entry->d_name);
>>              continue;
>>          }
>> @@ -914,10 +925,9 @@ pciWaitForDeviceCleanup(pciDevice *dev, const char *matcher)
>>      FILE *fp;
>>      char line[160];
>>      unsigned long long start, end;
>> -    int consumed;
>>      char *rest;
>> -    unsigned long long domain;
>> -    int bus, slot, function;
>> +    char *tmp;
>> +    unsigned int domain, bus, slot, function;
>
> Why the change in the size of domain?

domain is parsed and stored everywhere else as unsigned int. Do the
same here, there's no reason for domain to be handled as 64bit

Matthias

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]