Re: [PATCH v2 1/1] tests: qemucapabilities: update ppc64 qemu caps for 7.0.0 release

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 06, 2022 at 04:54:22PM -0300, Daniel Henrique Barboza wrote:
> No relevant changes since the last update from 7.0.0-rc2. Sending it so
> we're sure that we don't need to worry about ppc64 caps for the 7.0.0
> release anymore.

There are actually a few additional features available in this build:

  <flag name='memory-backend-file.pmem'/>
  <flag name='virtio-gpu-gl-pci'/>
  <flag name='virtio-vga-gl'/>

Not sure how much of that is because of build configuration rather
than changes in QEMU. Probably all of it :)


Regardless, considering the above I would say that the commit message
is not accurate. Would you be okay with something like

  There are no major changes since 7.0.0-rc2, but a few additional
  features are enabled in this build.

? If so, I can amend the commit message and push the patch as

  Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>


As a side note, it's unfortunate that this sort of small change gets
lost in the noise when updating capabilities. I wonder if anything
can be done about it.

-- 
Andrea Bolognani / Red Hat / Virtualization




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux