* AUTHORS: Add recent contributors. --- > > - *libVer = LIBVIR_VERSION_NUMBER; > > - ret = 0; > > + *libVer = LIBVIR_VERSION_NUMBER; > > + return 0; > > error: > > virDispatchError(conn); > > return ret; > > This change is fine. It would be wrong to report an error there. > I'd insert a blank line after the "return 0;" Done, and pushed. I'm also pushing this followup as trivial. And in doing so, I noticed that we incorrectly attributed one patch to Philip Hahn instead of Philipp Hahn. AUTHORS | 3 ++++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/AUTHORS b/AUTHORS index 1fa97b6..d6f025e 100644 --- a/AUTHORS +++ b/AUTHORS @@ -95,6 +95,9 @@ Patches have also been contributed by: Rolf Eike Beer <eike@xxxxxxxxxx> Wolfgang Mauerer <wolfgang.mauerer@xxxxxxxxxxx> Philipp Hahn <hahn@xxxxxxxxxxxxx> + Ed Swierk <eswierk@xxxxxxxxxxxxxxxxxx> + Paolo Smiraglia <paolo.smiraglia@xxxxxxxxx> + Sharadha Prabhakar <sharadha.prabhakar@xxxxxxxxxx> [....send patches to get your name here....] -- 1.6.6.1 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list