On Wed, May 04, 2022 at 01:11:24PM +0200, Victor Toso wrote: > This makes madatory to *not* add 'v' to version number. *mandatory > @@ -2218,7 +2218,7 @@ class docBuilder: > return_comment="") -> (str, str, str): > since = "" > if comment is not None: > - comment_match = re.search(r"\(?Since: v?(\d+\.\d+\.\d+\.?\d?)\)?", > + comment_match = re.search(r"\(?Since: (\d+\.\d+\.\d+\.?\d?)\)?", > comment) > if comment_match: > # Remove Since tag from the comment > @@ -2229,7 +2229,7 @@ class docBuilder: > since = comment_match.group(1) > > if since == "" and return_comment is not None: > - return_match = re.search(r"\(?Since: v?(\d+\.\d+\.\d+\.?\d?)\)?", > + return_match = re.search(r"\(?Since: (\d+\.\d+\.\d+\.?\d?)\)?", > return_comment) Needless to say, it would be amazing if this didn't have to be changed in two separate spots... Lots of opportunities for refactoring for someone with a strong will and a stronger stomach :) Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx> and pushed along with the previous patch. -- Andrea Bolognani / Red Hat / Virtualization
