On 4/26/22 22:38, Liang Yan wrote: > We do not need VIR_DOMAIN_VIRT_QEMU to get qemu default > version. With the 'os_type' and 'arch'in capabilities, > we could identify 'emulator' which is enough to get the version. > > Actually VIR_DOMAIN_VIRT_QEMU is not the only domain virt type for > qemu driver, there are VIR_DOMAIN_VIRT_KVM and VIR_DOMAIN_VIRT_HVF. > If TCG is disabled in qemu, it will cause the error that could not > find suitable emulater when access version. > > Signed-off-by: Liang Yan <lyan@xxxxxxxxxxxxxxx> > --- > src/qemu/qemu_capabilities.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx> and pushed. Congratulations on your first libvirt contribution! Michal
