On Thu, Apr 28, 2022 at 05:55:41PM +0100, Daniel P. Berrangé wrote: > On Thu, Apr 28, 2022 at 08:33:46AM -0700, Andrea Bolognani wrote: > > In other words, the current implementation of g_poll() on macOS > > doesn't follow the contract defined by GLib itself. It seems to me > > that this is a (fairly serious) bug in the library, no? > > It is significant, but long standing. GLib actually had this behaviour > forever on macOS, but it regressed when Meson was introduced, until > the recent fix. > > The question is whether efficiency trumps API semantics. Normally I'm > heavily biased towards API semantics, but poll is a performance > critical API, so it isn't so easy to declare we must workaround all > the quirks. > > I filed a bug to raise the subject for discussion though > > https://gitlab.gnome.org/GNOME/glib/-/issues/2644 That's an excellent bug report! Thanks for spending time on it, and let's see where the upstream discussion leads :) -- Andrea Bolognani / Red Hat / Virtualization
