On Thu, Apr 28, 2022 at 04:20:13PM +0200, Claudio Fontana wrote:
> I actually think I found the problem. It needs to be put explicitly into a list
> of methods that require conn, like NodeSetMemoryParameters.
Ah, lucky someone already hit the same problem scenario
>
> Here is the change:
>
> commit 192d8e56e88c00ede94768f6f73c6be64f31c789 (HEAD -> api_draft)
> Author: Claudio Fontana <cfontana@xxxxxxx>
> Date: Thu Apr 28 08:16:27 2022 -0600
>
> gendispatch: add DomainRestoreParametersFlags as requiring conn argument
>
> Signed-off-by: Claudio Fontana <cfontana@xxxxxxx>
>
> diff --git a/src/rpc/gendispatch.pl b/src/rpc/gendispatch.pl
> index 9f5bf0e316..bce88cfc52 100755
> --- a/src/rpc/gendispatch.pl
> +++ b/src/rpc/gendispatch.pl
> @@ -637,7 +637,10 @@ elsif ($mode eq "server") {
> } elsif ($args_member =~ m/^remote_typed_param (\S+)<(\S+)>;/) {
> push(@vars_list, "virTypedParameterPtr $1 = NULL");
> push(@vars_list, "int n$1 = 0");
> - if ($call->{ProcName} eq "NodeSetMemoryParameters") {
> +
> + # NB: if your new API starts with remote_typed_params, enter it here if you need
> + # the conn arg to be passed first!
> + if ($call->{ProcName} eq "NodeSetMemoryParameters" || $call->{ProcName} eq "DomainRestoreParametersFlags") {
> push(@args_list, $conn_var);
> }
> push(@args_list, "$1");
Looks ok to me.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
