On Wed, Apr 27, 2022 at 11:32:41AM +0200, Paolo Bonzini wrote:
> On 4/25/22 10:21, Martin Kletzander wrote:
> > @@ -4188,12 +4188,15 @@ void vnc_display_open(const char *id, Error **errp)
> > vd->ledstate = 0;
> > audiodev = qemu_opt_get(opts, "audiodev");
> > - if (audiodev) {
> > - vd->audio_state = audio_state_by_name(audiodev);
> > - if (!vd->audio_state) {
> > - error_setg(errp, "Audiodev '%s' not found", audiodev);
> > - goto fail;
> > - }
> > + if (!audiodev) {
> > + error_setg(errp, "Audiodev parameter for vnc required");
> > + goto fail;
> > + }
> > +
>
> Wouldn't this break "-vnc :0"? You can just ignore the audio commands if
> vd->audio_state is NULL.
Yep, that's wha I suggested with skipping advertizing VNC_ENCODING_AUDIO
when audiodev is NULL
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
