Re: [PATCH v2 3/8] Validate remote store NVRAM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 26, 2022 at 16:16:11 +0530, Rohit Kumar wrote:
> 
> On 21/04/22 8:36 pm, Peter Krempa wrote:
> > On Thu, Apr 21, 2022 at 16:52:54 +0200, Peter Krempa wrote:
> > > On Fri, Apr 08, 2022 at 10:48:46 -0700, Rohit Kumar wrote:
> > > > Remote store NVRAM feature is being enabled only
> > > > if it supports 'blockdev' capability.
> > > > 
> > > > Signed-off-by: Prerna Saxena <prerna.saxena@xxxxxxxxxxx>
> > > > Signed-off-by: Florian Schmidt <flosch@xxxxxxxxxxx>
> > > > Signed-off-by: Rohit Kumar <rohit.kumar3@xxxxxxxxxxx>
> > > > ---
> > > >   src/qemu/qemu_validate.c | 22 ++++++++++++++++++++++
> > > >   1 file changed, 22 insertions(+)
> > > > 
> > > > diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c
> > > > index 96f5427678..2a961b1f50 100644
> > > > --- a/src/qemu/qemu_validate.c
> > > > +++ b/src/qemu/qemu_validate.c
> > > > @@ -611,6 +611,25 @@ qemuValidateDomainDefBoot(const virDomainDef *def)
> > > >   }
> > > As noted in 2/8, this will need to be moved earlier.
> Ack.

If you don't have any additional points to raise or a discussion to
start, there's no need to acknowledge every point I make in a review.

For anything you acknowledge, simply do what was requested in the next
version.

Here I had to spend time opening a message where simply isn't anything
for me to respond to.




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux