On Tue, Mar 30, 2010 at 05:30:56PM -0400, David Allan wrote:
> ---
> docs/schemas/domain.rng | 8 ++++++++
> src/conf/domain_conf.c | 12 ++++++++++++
> src/conf/domain_conf.h | 1 +
> src/libvirt_private.syms | 3 +++
> src/qemu/qemu_conf.c | 12 ++++++++++++
> src/util/macvtap.c | 13 +++++++++++++
> src/util/macvtap.h | 4 ++++
> 7 files changed, 53 insertions(+), 0 deletions(-)
>
> diff --git a/docs/schemas/domain.rng b/docs/schemas/domain.rng
> index d804301..5917f60 100644
> --- a/docs/schemas/domain.rng
> +++ b/docs/schemas/domain.rng
> @@ -794,6 +794,11 @@
> <ref name="bridgeMode"/>
> </attribute>
> </optional>
> + <optional>
> + <attribute name="profileid">
> + <ref name="profileID"/>
> + </attribute>
> + </optional>
> <empty/>
> </element>
> <ref name="interface-options"/>
> @@ -1647,6 +1652,9 @@
> <param name="pattern">(vepa|bridge|private)</param>
> </data>
> </define>
> + <define name="profileID">
> + <data type="string"/>
> + </define>
> <define name="addrMAC">
> <data type="string">
> <param name="pattern">([a-fA-F0-9]{2}:){5}[a-fA-F0-9]{2}</param>
I think this would be better off as a new element within interface, so
that if we need more data associated with the profile we can provide
it. eg perhaps something like
<switchport profile='XYZ'/>
Wouldn't this also be valid for the type=bridge networking mode, since
that is connecting VMs to the LAN too.
Regards,
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list