On Fri, Apr 22, 2022 at 10:05:41AM -0700, Andrea Bolognani wrote: > On Fri, Apr 22, 2022 at 06:54:25PM +0200, Victor Toso wrote: > > The itching to change the code all around is still here. I > > actually created another (local) branch to put some fixes and > > removing dead code... but I knew if I started reworking things it > > would consume more time to reach the end goal, > > libvirt-go-module's MR. > > I completely agree that you should focus on getting the feature > working, even if it requires changing the script in less than ideal > ways. It's not like you'd be ruining a flawless piece of art ;) > > > I'm finishing the last touches of v4 and I plan to send it > > without this addressed. Later, perhaps Today, I'll add a patch on > > top that can either be an +1 or squashed in to address this. > > Please don't post patches that have known issues in them. It's very > unlikely that anyone will look at v4 until Monday anyway, so just > take the time you need to fix this and post v4 once you've done so. Ok!
Attachment:
signature.asc
Description: PGP signature
