Re: [PATCH v3 07/30] docstring: enums: admin: Add 'Since version' metadata

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 20, 2022 at 21:07:56 +0200, Victor Toso wrote:
> Either create or append to existing docstring, the version (git tag)
> that a given enum value was introduced in the format:
> 
>     Since: v1.2.3
> 
> Signed-off-by: Victor Toso <victortoso@xxxxxxxxxx>
> ---
>  include/libvirt/libvirt-admin.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/include/libvirt/libvirt-admin.h b/include/libvirt/libvirt-admin.h
> index e414f776e4..f65886f20d 100644
> --- a/include/libvirt/libvirt-admin.h
> +++ b/include/libvirt/libvirt-admin.h

This looks good on the first look, although there's a possibility that
for some reason these might not be usable e.g. by preventing inclusion
of the header. Unfortunately I don't remember the history and don't feel
like digging in such old code.

Reviewed-by: Peter Krempa <pkrempa@xxxxxxxxxx>




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux