On 3/2/22 10:48, Daniel P. Berrangé wrote: > On Wed, Mar 02, 2022 at 09:12:55AM +0100, Peter Krempa wrote: >> On Tue, Mar 01, 2022 at 17:46:44 +0100, Erik Skultety wrote: >>> On Tue, Feb 15, 2022 at 02:47:44PM +0100, Peter Krempa wrote: >>>> As of April 23 2022, Ubuntu 20.04 will be out for two years, which per >>>> our platform support policy means we no longer have to support >>>> Ubuntu 18.04. >>> >>> Would you mind contributing the patch to libvirt-ci and regenerating the >>> gitlab.yml config with lcitool from manifest when the time comes? :) >> >> So ... is libvirt-ci always fully mirroring what libvirt does? >> >> AFAIU lcitool is used at least within the qemu project and I didn't >> really check to see whether qemu will continue caring about Ubuntu 18.04 >> and the READMEs in libvirt-ci aren't clearing up the expectations >> either. > > Accidentally (on purpose), I proposed a platform support matrix for QEMU > that has the same rules as libvirt. So broadly speaking both projects > will target the same platforms at any given point in time. > > None the less we should *NOT* remove platforms from libvirt-ci as the > first step. We should remove the platforms from usage in all projects > first. Removing from libvirt-ci should be the last thing. > > This is because while projects broadly follow the same goals, the > timeframe in which those goals are applied may not line up exactly. > There can be constraints from the software release cycles. QEMU is > about to enter freeze, but if they encounter problems in CI they > still want to be able to pull in updates from libvirt-ci, without > Ubuntu 18.04 support being ripped out from under their feet. > But what we could do is the following: diff --git i/guests/lcitool/lcitool/ansible/playbooks/build/jobs/defaults.yml w/guests/lcitool/lcitool/ansible/playbooks/build/jobs/defaults.yml index 4f73393..7676bff 100644 --- i/guests/lcitool/lcitool/ansible/playbooks/build/jobs/defaults.yml +++ w/guests/lcitool/lcitool/ansible/playbooks/build/jobs/defaults.yml @@ -17 +16,0 @@ all_machines: - - ubuntu-1804 diff --git i/guests/lcitool/lcitool/ansible/playbooks/build/projects/libvirt-dbus.yml w/guests/lcitool/lcitool/ansible/playbooks/build/projects/libvirt-dbus.yml index 4603135..1ff2dd4 100644 --- i/guests/lcitool/lcitool/ansible/playbooks/build/projects/libvirt-dbus.yml +++ w/guests/lcitool/lcitool/ansible/playbooks/build/projects/libvirt-dbus.yml @@ -26 +25,0 @@ - - ubuntu-1804 diff --git i/guests/lcitool/lcitool/ansible/playbooks/build/projects/libvirt-sandbox.yml w/guests/lcitool/lcitool/ansible/playbooks/build/projects/libvirt-sandbox.yml index dee3dbe..0b74d3b 100644 --- i/guests/lcitool/lcitool/ansible/playbooks/build/projects/libvirt-sandbox.yml +++ w/guests/lcitool/lcitool/ansible/playbooks/build/projects/libvirt-sandbox.yml @@ -14 +13,0 @@ - - ubuntu-1804 diff --git i/guests/lcitool/lcitool/ansible/playbooks/build/projects/libvirt.yml w/guests/lcitool/lcitool/ansible/playbooks/build/projects/libvirt.yml index 25e5bcb..d5e0bf7 100644 --- i/guests/lcitool/lcitool/ansible/playbooks/build/projects/libvirt.yml +++ w/guests/lcitool/lcitool/ansible/playbooks/build/projects/libvirt.yml @@ -26 +25,0 @@ - - ubuntu-1804 Michal
