On Tue, Mar 29, 2022 at 06:38:11PM +0100, John Levon wrote: > From: John Levon <john.levon@xxxxxxxxxxx> > > In 0895a0e, it was noted that the "sockets" value in the topology > section of capabilities reflects not the number of sockets per NUMA > node, not the total number. > > Unfortunately, the fix was applied to the wrong place: the domain XML > format documentation, not that for the capabilities output. And, in > fact, the domain XML interprets "sockets" as the total number, not a > per-node value. > > Back out this change in favour of a note in the capabilities > documentation instead. > > Fixes: 0895a0e75d13874254218e16dc66dcad673671d3 > Suggested-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> > Signed-off-by: John Levon <john.levon@xxxxxxxxxxx> > --- > docs/formatcaps.html.in | 5 ++++- > docs/formatdomain.rst | 12 ++++++------ > 2 files changed, 10 insertions(+), 7 deletions(-) Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> and pushed With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|