Re: libvirt: introduce VIR_DOMAIN_DESTROY_REMOVE_LOGS flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



пн, 28 февр. 2022 г. в 14:13, Nikolay Shirokovskiy
<nshirokovskiy@xxxxxxxxxxxxx>:
>
> Hi, all!
>
> What do you think?

Hi, please take a look at this series.

Nikolay

>
> пн, 14 февр. 2022 г. в 15:19, Nikolay Shirokovskiy <nshirokovskiy@xxxxxxxxxxxxx>:
>>
>> The patch series based on discussion in RFC [1].
>>
>> I wonder if we'd better add some property like "transient logs" instead
>> of adding a flag to destoy API.
>>
>> Yes libguestfs uses virDomainDestroyFlags to terminate a VM and it is
>> intended client of this new flag but it or other clients may want to use
>> shutdown API or use autodestroy domains with same log behaviour. Then
>> for the current task we only need to support this property in domain xml
>> I guess.
>>
>> [1] removing VMs logs
>> https://listman.redhat.com/archives/libvir-list/2022-February/msg00273.html
>>
>> Nikolay Shirokovskiy (3):
>>   libvirt: introduce VIR_DOMAIN_DESTROY_REMOVE_LOGS flag
>>   qemu: support VIR_DOMAIN_DESTROY_REMOVE_LOGS flag
>>   tools: support --remove-logs flag on destroing domain
>>
>>  docs/manpages/virsh.rst          |  7 +++++-
>>  include/libvirt/libvirt-domain.h |  1 +
>>  src/libvirt-domain.c             |  6 +++++
>>  src/qemu/qemu_domain.c           | 41 ++++++++++++++++++++++++++++++++
>>  src/qemu/qemu_domain.h           |  4 ++++
>>  src/qemu/qemu_driver.c           |  8 ++++++-
>>  tools/virsh-domain.c             |  8 ++++++-
>>  7 files changed, 72 insertions(+), 3 deletions(-)
>>
>> --
>> 2.31.1
>>





[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux