Re: [PATCH 1/4] conf: Introduce memory allocation threads

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3/24/22 12:49, Martin Kletzander wrote:
> On Thu, Mar 24, 2022 at 11:22:54AM +0000, Daniel P. Berrangé wrote:
>> On Thu, Mar 24, 2022 at 12:15:43PM +0100, Michal Prívozník wrote:
>>> On 3/24/22 10:26, Martin Kletzander wrote:
>>> > On Tue, Mar 22, 2022 at 04:05:14PM +0100, Michal Privoznik wrote:
>>> >> Since its commit v5.0.0-rc0~75^2~1^2~3 QEMU is capable of
>>> >
>>> > Anything wrong with the old "commit ffac16fab33b" ?
>>>
>>> Not specifically no. But I do it this ways so that it's visible at the
>>> first sight what QEMU version was this feature introduced in. And it
>>> works with 'git show' too (for those who are interested in the
>>> particular commit). IOW:
>>>
>>>   "Since its commit v5.0.0-rc0~75^2~1^2~3 QEMU is capable .."
>>
>> How do you generate such a reference ? It is different from
>> what a simple git describe shows
>>
>> $ git describe --match 'v*' ffac16fab33b
>> v4.2.0-1618-gffac16fab3
>>
>> and I feel the git describe output is much nicer, as it actually
>> includes the commit short hash still.
>>
> 
> I think Michal used --contains which clearly shows from which tag is the
> commit included, but tracking down through merge commits is what makes
> it look like the above.

Indeed.

qemu.git $ git describe --contains ffac16fab33bb42f17e47624985220c1fd864e9d
v5.0.0-rc0~75^2~1^2~3

Michal




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux