Re: [PATCH] virnwfilterobj: Don't use virObjectLockGuard() with virNWFilterObj

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 18, 2022 at 11:43:34AM +0100, Michal Privoznik wrote:
> While its name would suggest that virNWFilterObj is an actual
> virObject it is not. It's a plain structure (with virMutex as its
> first member). Therefore, when locking the struct
> virObjectLockGuard() can' be used and virLockGuardLock() must be
> used instead.
> 
> Spotted-by: Martin Kletzander <mkletzan@xxxxxxxxxx>
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---

This fixes the crasher in the integration CI we saw yesterday:
Reviewed-by: Erik Skultety <eskultet@xxxxxxxxxx>

After this patch, there's still a deadlock [1], but you should push this fix in
the meantime.

[1] https://paste.centos.org/view/6a7bfd66




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux