On 3/17/22 1:30 PM, Michal Prívozník wrote: > On 3/17/22 13:28, Claudio Fontana wrote: >> Hello all, >> >> while experimenting with upstream libvirt, I encountered the following segfault when trying to virt-install a centos7 guest: > > I've pushed fix earlied today: > > commit fcbb8e916bb69990e1f2cfc7a0066e3213daa2c5 > Author: Michal Prívozník <mprivozn@xxxxxxxxxx> > AuthorDate: Thu Mar 17 09:19:39 2022 +0100 > Commit: Michal Prívozník <mprivozn@xxxxxxxxxx> > CommitDate: Thu Mar 17 09:45:38 2022 +0100 > > virnetdev: Use VIR_WITH_MUTEX_LOCK_GUARD in virNetDevGenerateName() > > The virNetDevGenerateName() function uses a global array of > virNetDevGenName structs to find next unused name for network > device. This obviously needs some locking and in fact each member > of the array has its own lock. However, these members are not > virObjects, they are just plain structs, therefore > VIR_WITH_MUTEX_LOCK_GUARD() must be used instead of > VIR_WITH_OBJECT_LOCK_GUARD() to lock individual mutexes. > > Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> > Reviewed-by: Pavel Hrdina <phrdina@xxxxxxxxxx> > > Michal > wow that was quick.. thanks a lot! Claudio
