Re: [libvirt PATCH] Add Alpine builds to CI

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 15, 2022 at 12:15:03PM +0100, Martin Kletzander wrote:
> Signed-off-by: Martin Kletzander <mkletzan@xxxxxxxxxx>
> ---
>  ci/containers/alpine-314.Dockerfile  | 82 ++++++++++++++++++++++++++++
>  ci/containers/alpine-edge.Dockerfile | 81 +++++++++++++++++++++++++++
>  ci/gitlab.yml                        | 35 +++++++++++-
>  ci/manifest.yml                      |  8 +++
>  4 files changed, 204 insertions(+), 2 deletions(-)
>  create mode 100644 ci/containers/alpine-314.Dockerfile
>  create mode 100644 ci/containers/alpine-edge.Dockerfile
> 
...

> diff --git a/ci/gitlab.yml b/ci/gitlab.yml
> index cc03a2fe49f8..a19ec2a23f09 100644
> --- a/ci/gitlab.yml
> +++ b/ci/gitlab.yml
> @@ -10,8 +10,7 @@
>    stage: containers
>    needs: []
>    services:
> -    - name: registry.gitlab.com/libvirt/libvirt-ci/docker-dind:master
> -      alias: docker
> +    - docker:dind
>    before_script:
>      - export TAG="$CI_REGISTRY_IMAGE/ci-$NAME:latest"
>      - export COMMON_TAG="$CI_REGISTRY/libvirt/libvirt/ci-$NAME:latest"
> @@ -87,6 +86,20 @@ x86_64-almalinux-8-container:
>      NAME: almalinux-8

^This should be a separate commit.

...

> diff --git a/ci/manifest.yml b/ci/manifest.yml
> index 87d923ae7839..26704bef2362 100644
> --- a/ci/manifest.yml
> +++ b/ci/manifest.yml
> @@ -18,6 +18,14 @@ targets:
>            RPM: skip
>            CC: clang
>  
> +  alpine-314:
> +    jobs:
> +      - arch: x86_64
> +
> +  alpine-edge:
> +    jobs:
> +      - arch: x86_64

Alpine Edge is flaky so you need to mark it as 'allow_failure' here.

With those bits addressed:
Reviewed-by: Erik Skultety <eskultet@xxxxxxxxxx>

> +
>    centos-stream-8:
>      jobs:
>        - arch: x86_64
> -- 
> 2.35.1
> 




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux