Re: [PATCH] tests: don't use auto-generated NVRAM path in tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/23/22 14:03, Daniel P. Berrangé wrote:
> By using the auto-generated NVRAM path in test data files, we won't see
> bugs where a user specified path gets accidentally overwritten by a
> post-parse callback, or VM startup. For example, this caused us to miss
> the bug fixed by:
> 
>   commit 24adb6c7a6cbd8ce5f9de67e6af5d89e0e57c270
>   Author: Michal Prívozník <mprivozn@xxxxxxxxxx>
>   Date:   Wed Feb 23 08:50:44 2022 +0100
> 
>     qemu: Don't regenerate NVRAM path if parsed from domain XML
> 
> Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
> ---
>  tests/qemuxml2argvdata/aarch64-acpi-uefi.args                   | 2 +-
>  tests/qemuxml2argvdata/aarch64-acpi-uefi.xml                    | 2 +-
>  tests/qemuxml2argvdata/aarch64-noacpi-uefi.args                 | 2 +-
>  tests/qemuxml2argvdata/aarch64-noacpi-uefi.xml                  | 2 +-
>  .../qemuxml2argvdata/aarch64-virt-graphics.aarch64-latest.args  | 2 +-
>  tests/qemuxml2argvdata/aarch64-virt-graphics.xml                | 2 +-
>  .../qemuxml2argvdata/aarch64-virt-headless.aarch64-latest.args  | 2 +-
>  tests/qemuxml2argvdata/aarch64-virt-headless.xml                | 2 +-
>  tests/qemuxml2argvdata/bios-nvram-os-interleave.xml             | 2 +-
>  tests/qemuxml2argvdata/bios-nvram-secure.args                   | 2 +-
>  tests/qemuxml2argvdata/bios-nvram-secure.xml                    | 2 +-
>  tests/qemuxml2argvdata/bios-nvram.args                          | 2 +-
>  tests/qemuxml2argvdata/bios-nvram.xml                           | 2 +-
>  tests/qemuxml2argvdata/hvf-aarch64-virt-headless.args           | 2 +-
>  tests/qemuxml2argvdata/hvf-aarch64-virt-headless.xml            | 2 +-
>  tests/qemuxml2argvdata/os-firmware-bios.xml                     | 2 +-
>  .../qemuxml2argvdata/os-firmware-efi-secboot.x86_64-latest.args | 2 +-
>  tests/qemuxml2argvdata/os-firmware-efi-secboot.xml              | 2 +-
>  tests/qemuxml2argvdata/os-firmware-efi.x86_64-latest.args       | 2 +-
>  tests/qemuxml2argvdata/os-firmware-efi.xml                      | 2 +-
>  tests/qemuxml2argvdata/q35-acpi-uefi.args                       | 2 +-
>  tests/qemuxml2argvdata/q35-acpi-uefi.xml                        | 2 +-
>  tests/qemuxml2argvdata/q35-noacpi-uefi.xml                      | 2 +-
>  .../qemuxml2xmloutdata/aarch64-virt-graphics.aarch64-latest.xml | 2 +-
>  .../qemuxml2xmloutdata/aarch64-virt-headless.aarch64-latest.xml | 2 +-
>  tests/qemuxml2xmloutdata/bios-nvram-os-interleave.xml           | 2 +-
>  tests/qemuxml2xmloutdata/bios-nvram.xml                         | 2 +-
>  tests/qemuxml2xmloutdata/hvf-aarch64-virt-headless.xml          | 2 +-
>  tests/qemuxml2xmloutdata/os-firmware-bios.x86_64-latest.xml     | 2 +-
>  .../os-firmware-efi-secboot.x86_64-latest.xml                   | 2 +-
>  tests/qemuxml2xmloutdata/os-firmware-efi.x86_64-latest.xml      | 2 +-
>  31 files changed, 31 insertions(+), 31 deletions(-)

Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx>

Michal




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux