On 2/15/22 19:54, Daniel P. Berrangé wrote: > This demonstrates that > > <os> > <loader readonly='yes' type='pflash'>/usr/share/OVMF/OVMF_CODE.fd</loader> > <nvram template="/usr/share/OVMF/OVMF_VARS.fd"/> > </os> > > gets expanded to give a per-VM NVRAM path. > > Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> > --- > .../bios-nvram-template.x86_64-latest.args | 37 +++++++++++++++++++ > .../qemuxml2argvdata/bios-nvram-template.xml | 21 +++++++++++ > tests/qemuxml2argvtest.c | 1 + > 3 files changed, 59 insertions(+) > create mode 100644 tests/qemuxml2argvdata/bios-nvram-template.x86_64-latest.args > create mode 100644 tests/qemuxml2argvdata/bios-nvram-template.xml I wanted to suggest introducing the same test case for xml2xml test, but the nvram path generated looks weird after I did that: <nvram template='/usr/share/OVMF/OVMF_VARS.fd'>/bad-test-used-env-home/.config/libvirt/qemu/nvram/test-bios_VARS.fd</nvram> We're probably missing some mock somewhere, so I'll save that for future work. Michal