On 2/11/22 18:39, Andrea Bolognani wrote: > I initially started looking into this because of > > https://gitlab.com/libvirt/libvirt/-/issues/273 > > I have now convinced myself that we don't need to change the way we > quote things, but in the process I have accumulated several > improvements and one bug fix. > > Andrea Bolognani (11): > virbuftest: Increase coverage > virbuffer: Simplify virBufferEscapeShell() > virnetsockettest: Drop unnecessary backslash > virnetsockettest: Move opening quote > virnetsockettest: Improve indentation > virnetclient: Improve spacing of ssh script > virnetclient: Use 'if' consistently > virnetsockettest: Tweak input for test 7 > virnetsockettest: Allow changing the proxy parameter > virnetsockettest: Increase coverage > virnetclient: Escape socket path > > src/rpc/virnetclient.c | 20 +++--- > src/util/virbuffer.c | 17 ++--- > tests/virbuftest.c | 9 ++- > tests/virnetsockettest.c | 149 ++++++++++++++++++++++++++++----------- > 4 files changed, 133 insertions(+), 62 deletions(-) > For patches 1-5,8-10: Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx> You'll need to tweak the expected output in some patches, because patches 6 and 7 are missing now, but that's easy to do. Michal
