Re: [libvirt] [PATCH] tests: teach syntax-check that virDomainDefFree has free-like semantics

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/25/2010 02:56 PM, Jim Meyering wrote:
> Thanks for highlighting that.
> Our syntax-check rule should have caught it.
> With the following change, it does, along with one other:
> 
>     src/conf/domain_conf.c: if (domain->newDef)
>                     virDomainDefFree(domain->newDef)
>     src/test/test_driver.c: if (def)
>             virDomainDefFree(def)
>     maint.mk: found useless "if" before "free" above
>     make: *** [sc_avoid_if_before_free] Error 1
> 
> This also fixes the one not fixed by Jiri's change.

ACK

-- 
Eric Blake   eblake@xxxxxxxxxx    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]