Re: [libvirt PATCH 00/11] Automatic mutex management

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/7/22 14:12, Tim Wiederhake wrote:
> Use the recently implemented VIR_LOCK_GUARD and VIR_WITH_MUTEX_LOCK_GUARD
> to simplify mutex management.
> 
> This made a solitary "virMutexUnlock()" call without previous call to
> "virMutexLock()" in ch_driver.c obvious, which is removed in patch #8.
> 
> Tim Wiederhake (11):
>   virthreadpool: Use automatic memory management
>   virthreadpool: Cleanup
>   libxl: Use automatic memory management
>   lxc: Prepare virLXCDriverGetCapabilities for automatic mutex
>     management
>   lxc: Use automatic mutex management
>   ch: Prepare virCHDriverGetCapabilities for automatic mutex management
>   ch: Use automatic mutex management
>   ch: Remove solitary virMutexUnlock
>   network: Use automatic mutex management
>   bhyve_driver: Use automatic mutex management
>   node_device: Use automatic mutex management
> 
>  src/bhyve/bhyve_conf.c               |  7 +--
>  src/bhyve/bhyve_driver.c             | 12 ----
>  src/bhyve/bhyve_utils.h              |  3 -
>  src/ch/ch_conf.c                     | 31 +++++-----
>  src/ch/ch_conf.h                     | 10 ----
>  src/ch/ch_driver.c                   | 29 +++++----
>  src/libxl/libxl_conf.c               |  8 +--
>  src/libxl/libxl_conf.h               | 12 ----
>  src/libxl/libxl_logger.c             | 20 +++----
>  src/lxc/lxc_conf.c                   | 41 ++++++-------
>  src/lxc/lxc_conf.h                   |  9 ---
>  src/lxc/lxc_controller.c             | 25 ++++----
>  src/lxc/lxc_fuse.c                   | 12 ++--
>  src/network/bridge_driver.c          | 41 ++++---------
>  src/node_device/node_device_driver.c | 23 ++-----
>  src/node_device/node_device_udev.c   | 52 +++++++---------
>  src/util/virthreadpool.c             | 90 ++++++++--------------------
>  17 files changed, 138 insertions(+), 287 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx>

And sorry for the conflict, but it's trivial enough to resolve.

Michal




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux