Re: [PATCH] qemu: fix formatting of pflash readonly attribute

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On a Monday in 2022, Daniel P. Berrangé wrote:
When the <loader> had an explicit readonly='no' attribute we
accidentally still marked the plfash as readonly due to the
bad conversion from virTristateBool to bool.

Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
---
src/qemu/qemu_domain.c                        |  3 +-
.../bios-nvram-implicit-rw.x86_64-latest.args | 39 +++++++++++++++++++
.../bios-nvram-implicit-rw.xml                | 35 +++++++++++++++++
.../bios-nvram-rw.x86_64-latest.args          | 39 +++++++++++++++++++
tests/qemuxml2argvdata/bios-nvram-rw.xml      | 35 +++++++++++++++++
tests/qemuxml2argvtest.c                      |  2 +
6 files changed, 152 insertions(+), 1 deletion(-)
create mode 100644 tests/qemuxml2argvdata/bios-nvram-implicit-rw.x86_64-latest.args
create mode 100644 tests/qemuxml2argvdata/bios-nvram-implicit-rw.xml
create mode 100644 tests/qemuxml2argvdata/bios-nvram-rw.x86_64-latest.args
create mode 100644 tests/qemuxml2argvdata/bios-nvram-rw.xml


Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx>

Jano

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux