Re: [PATCH v3 3/3] qemu: gpu: Get pid without binary validation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/2/22 17:28, Vasiliy Ulyanov wrote:
> The binary validation in virPidFileReadPathIfAlive may fail with EACCES
> if the calling process does not have CAP_SYS_PTRACE capability.
> Therefore instead do only the check that the pidfile is locked by the
> correct process.
> 
> Fixes the same issue as with swtpm.
> 
> Signed-off-by: Vasiliy Ulyanov <vulyanov@xxxxxxx>
> ---
>  src/qemu/qemu_vhost_user_gpu.c | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/src/qemu/qemu_vhost_user_gpu.c b/src/qemu/qemu_vhost_user_gpu.c
> index ef198a4820..94e758f78d 100644
> --- a/src/qemu/qemu_vhost_user_gpu.c
> +++ b/src/qemu/qemu_vhost_user_gpu.c
> @@ -20,6 +20,8 @@
>  
>  #include <config.h>
>  
> +#include <fcntl.h>
> +

This doesn't look necessary.

Michal




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux