On a Thursday in 2022, Andrea Bolognani wrote:
In order to match the existing virStringParse*() and virStrTo*() functions, input arguments should come before output arguments.
Or, even better, the virStr* functions should be inverted to match the approach we do elsewhere (VIR_STRDUP, virCommand come to mind) where the output arguments come first. (Just like they do when you do an assignment.) Jano
Signed-off-by: Andrea Bolognani <abologna@xxxxxxxxxx> --- src/bhyve/bhyve_driver.c | 2 +- src/ch/ch_conf.c | 2 +- src/esx/esx_vi.c | 8 ++++---- src/lxc/lxc_driver.c | 2 +- src/nwfilter/nwfilter_ebiptables_driver.c | 4 ++-- src/openvz/openvz_conf.c | 2 +- src/util/virdnsmasq.c | 2 +- src/util/virfirewalld.c | 2 +- src/util/virstring.c | 10 +++++----- src/util/virstring.h | 6 +++--- src/vbox/vbox_common.c | 2 +- src/vmware/vmware_conf.c | 2 +- src/vz/vz_utils.c | 2 +- tests/testutilsqemu.c | 2 +- tests/utiltest.c | 4 ++-- tools/virt-host-validate-common.c | 2 +- 16 files changed, 27 insertions(+), 27 deletions(-)
Attachment:
signature.asc
Description: PGP signature
